Skip to content

feat: pin git runtime for git pusher#429

Merged
sbalabanov merged 1 commit into
mainfrom
feat/hermetic-pinned-git
Jul 23, 2026
Merged

feat: pin git runtime for git pusher#429
sbalabanov merged 1 commit into
mainfrom
feat/hermetic-pinned-git

Conversation

@sbalabanov

Copy link
Copy Markdown
Contributor

Summary

  • pin Git 2.55.0 from the Bazel Central Registry
  • inject absolute Git executable, helper, and template paths into the Git pusher
  • construct a controlled Git environment instead of inheriting host configuration
  • run the real-git tests against the Bazel-built runtime and assert its version
  • remove the PATH lookup and test skip when host Git is unavailable

This intentionally implements the source-built BCR option. The resulting Git binary still uses the host libc and the BCR build's /bin/sh.

Validation

  • ./tool/bazel test //submitqueue/extension/pusher/git:go_default_test --nocache_test_results --test_output=errors
  • ./tool/bazel test //... --test_tag_filters=-manual,-integration --test_output=errors
  • make check-tidy
  • make check-gazelle
  • make lint

The Git pusher test runs in approximately 2.7 seconds after the one-time BCR Git build.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sbalabanov
sbalabanov marked this pull request as ready for review July 22, 2026 23:58
@sbalabanov
sbalabanov requested review from a team and behinddwalls as code owners July 22, 2026 23:58
@sbalabanov
sbalabanov force-pushed the feat/hermetic-pinned-git branch 2 times, most recently from 2256851 to ab3ab60 Compare July 23, 2026 20:06
@sbalabanov
sbalabanov force-pushed the feat/hermetic-pinned-git branch from ab3ab60 to 6cbd105 Compare July 23, 2026 20:14
@sbalabanov
sbalabanov added this pull request to the merge queue Jul 23, 2026
@sbalabanov
sbalabanov removed this pull request from the merge queue due to a manual request Jul 23, 2026
@sbalabanov
sbalabanov merged commit 3f7d230 into main Jul 23, 2026
14 of 15 checks passed
@behinddwalls
behinddwalls deleted the feat/hermetic-pinned-git branch July 23, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants